improve support for argreduction comparisons #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arg reduction methods in
Variablereturn behave differently depending on thedimsparameter:dim=...ordim=None: return a dict containing the indices for all dimsdimas a list: return a dict containing the indices for the given dimsdimas a hashable: return a single int index for the raveled arrayWe thus need to construct the proper expected value to be able to check the result.